Skip to content

Optimise seshat:counters/3 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelklishin merged 2 commits into from
Nov 26, 2025
Merged

Optimise seshat:counters/3 #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0f34ee
Optimise seshat:counters/3
mkuratczyk Nov 26, 2025
eb2aec3
Optimise seshat:counters/3 for single-item name list
mkuratczyk Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions src/seshat.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,35 @@ delete(Group, Id) ->
-spec build_counters_map(counters:counters_ref(), fields_spec()) ->
#{atom() => integer()}.
build_counters_map(CRef, FieldsSpec) ->
build_counters_map(CRef, FieldsSpec, all).

%% Helper function to build the map of counters for a given CRef and FieldSpec
%% with optional filtering by Names
-spec build_counters_map(counters:counters_ref(), fields_spec(), all | [atom()]) ->
#{atom() => integer()}.
build_counters_map(CRef, FieldsSpec, all) ->
Fields = resolve_fields_spec(FieldsSpec),
lists:foldl(fun ({Name, Index, _Type, _Help}, Acc0) ->
Acc0#{Name => counters:get(CRef, Index)}
end, #{}, Fields);
build_counters_map(CRef, FieldsSpec, [Name]) ->
%% Optimized path for single name lookup
Fields = resolve_fields_spec(FieldsSpec),
case lists:keyfind(Name, 1, Fields) of
{Name, Index, _Type, _Help} ->
#{Name => counters:get(CRef, Index)};
false ->
#{}
end;
build_counters_map(CRef, FieldsSpec, Names) when is_list(Names) ->
Fields = resolve_fields_spec(FieldsSpec),
lists:foldl(fun ({Name, Index, _Type, _Help}, Acc0) ->
Acc0#{Name => counters:get(CRef, Index)}
case lists:member(Name, Names) of
true ->
Acc0#{Name => counters:get(CRef, Index)};
false ->
Acc0
end
end, #{}, Fields).

%% @doc Return a map with all metrics of all objects in the group
Expand Down Expand Up @@ -159,8 +185,7 @@ counters(Group, Id) ->
counters(Group, Id, Names) ->
case ets:lookup(seshat_counters_server:get_table(Group), Id) of
[#entry{cref = CRef, field_spec = FieldsSpec}] ->
AllCountersMap = build_counters_map(CRef, FieldsSpec),
maps:with(Names, AllCountersMap);
build_counters_map(CRef, FieldsSpec, Names);
_ ->
undefined
end.
Expand Down