Maintenance improvements for helper scripts.#17
Open
bfinney-thoughtworks wants to merge 6 commits intorabblerouser:masterfrom
Open
Maintenance improvements for helper scripts.#17bfinney-thoughtworks wants to merge 6 commits intorabblerouser:masterfrom
bfinney-thoughtworks wants to merge 6 commits intorabblerouser:masterfrom
Conversation
added 6 commits
April 26, 2018 15:41
These allow editors (those which recognise these hints) to know the syntax of the script, without needing a special filename nor shebang line.
For a non-program shell script, the shebang line is misleading. Instead, the file needs to be invoked *within* an existing shell, not run as a separate program.
The ‘tf’ program must be run with Bash specifically, not ‘sh’.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes improve the shell scripts editability (with programmer editors) and conformance to conventions (names, permissions, etc.).