Preload custom emoji on race detail page - #232
Open
fenhl wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
I was able to fix my test environment and can now confirm that this PR does what it's supposed to do in a simulated slow network. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the race detail page,
<link rel="preload">elements are added to the HTML head to load the category's custom emoji eagerly rather than only once they appear on the page. This is intended to fix an issue where some OoTR racers don't see the seed password, which is posted to chat and raceinfo as custom emoji a short time before the race starts.I'm having trouble logging into my test instance (will open a separate issue for it if I can't figure it out) so this is not yet tested.