Convert things to html on submission - #66
Open
Killklli wants to merge 3 commits into
Open
Conversation
I'm not entirely sure how I feel on this one, I thought I'd throw it in as an option. It dosen't render markdown back in the configure box and will just show the converted html.
deains
requested changes
Jul 27, 2020
deains
left a comment
deains
left a comment
Member
There was a problem hiding this comment.
This works better than I expected it would. Probably needs some tidying up before we go live with it though I think. I might be able to take a look at the styling stuff later this week if that's not your bag.
deains
approved these changes
Jul 28, 2020
deains
left a comment
deains
left a comment
Member
There was a problem hiding this comment.
👍 Happy with this, but gonna hold on merging until I can work on the styling a lil' bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure how I feel on this one, I thought I'd throw it in as an option.
It dosen't render markdown back in the configure box and will just show the converted html.
Relates to #27