Remove dependencies besides aiohttp - #6
Conversation
| continue_on = [ | ||
| # Exception types that will not cause the bot to shut down. | ||
| websockets.ConnectionClosed, | ||
| # websockets.ConnectionClosed, |
There was a problem hiding this comment.
I need to figure out what should be here for aiohttp websockets
There was a problem hiding this comment.
does aiohttp raise an exception on a clean disconnect from the websocket?
There was a problem hiding this comment.
Hi from the future, do you guys know any way I could test what happens for a clean disconnect? I think it might just be DisconnectedError or some subclass but not sure.
There was a problem hiding this comment.
Would probably make sense to continue for all HTTP issues, clean or otherwise since they (probably) don't point to any issue with the bot itself.
There was a problem hiding this comment.
Looks like I could just use ClientError? Or ClientResponseError and ClientConnectionError
There was a problem hiding this comment.
I changed it to ClientError for now. I want to test this then will make this not a draft
|
@andrew12 - I'm building a PR on top of this fork that adds support for creating race rooms, and editing existing race rooms, just as a heads up. If this isn't merged yet before this is done, I'll make a PR against this PR's branch with those changes. I 100% love the concept of just sticking with aiohttp. |
|
sorry I haven't had a chance to resolve the issues here yet, will see if I can soon |
Need to test!
b0a2b52 to
e989bfa
Compare
3 participants
Every other dependency has features that already in aiohttp so there's no need for the extras. I have changed the code to work with aiohttp only.