feat(cli): meta.route on every browser-touching command (iter-134) - #182
Merged
Conversation
iter-128 Theme D wired connection_meta::merge_route at only the two
commands central to that iteration (network, navigate --with-network).
This rolls it out to the remaining ~30 commands so meta.route
("daemon"/"direct") is present on every browser-touching command's
JSON envelope without --verbose, matching dogfood-62 finding #10.
navigate's plain run()/run_core(), click::run_core, type_text::run_core,
and wait::run_core didn't expose via_daemon to their run() callers, so
their signatures changed to return it alongside the result (wait's
--sleep-ms short-circuit reports None — it never opens a connection).
screenshot and tabs always report "direct": screenshot always uses
connect_direct (the daemon's watcher subscription breaks its two-step
capture protocol) and tabs bypasses ConnectedTab/the daemon entirely
via a raw RdpConnection::connect. sources.rs turned up during the
final envelope-construction audit missing a meta.connection block
entirely; only merge_route was added there, in scope for this
iteration.
Adds live_134_meta_route_all_commands (click/eval/screenshot/dom,
both connection modes) as the plan's AC.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The top-level OUTPUT FORMAT block and network's long_about only described meta.route from iter-128, when it covered just network and navigate --with-network. Note the iter-134 expansion to every browser-touching command. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…cedent DEC-027 (already on main) resolves Theme B's open opt-in-vs-default question before iter-143 starts, so tick that AC and drop the "decide first" framing. Also point Theme A at iter-134's merge_route helper as the established pattern to mirror for meta.source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connection_meta::merge_route(iter-128 Theme D) from justnetwork/navigate --with-networkto the remaining ~30 browser-touching commands, someta.route("daemon"/"direct") is present and correct on every one, unconditionally (not gated by--verbose).navigate's plainrun(),click::run_core,type_text::run_core, andwait::run_coredidn't exposevia_daemonto theirrun()wrappers — their signatures now return it alongside the result (waitreportsNonefor its--sleep-msshort-circuit, which never opens a connection).screenshotandtabsalways report"direct"since they never route through the daemon (screenshot always usesconnect_direct; tabs uses a rawRdpConnection::connectthat bypasses the daemon entirely).sources.rsturned up during the final envelope-construction audit missing ameta.connectionblock altogether — addedmerge_routethere too (the missing connection block is a separate pre-existing gap, left out of scope).--help(top-level OUTPUT FORMAT block +network's long_about).Test plan
cargo fmt,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace -qall cleanlive_134_meta_route_all_commands(click/eval/screenshot/dom, both--no-daemonand daemon-routed modes) passes against real headless Firefoxcargo run -p xtask -- check-iteration-ready --plan kb/iterations/iteration-134-meta-route-all-commands.md --base origin/main— 10/10 PASS (withFF_RDP_LIVE_TESTS=1for the dogfood-script gate)🤖 Generated with Claude Code## Claims vs code
<generated 2026-08-12T05:21:40Z by ralph-loop>
live_134_meta_route_all_commands→ ✅ matched in diffRdpConnection::connect→ ✅ matched in diff#10→ ❌ no match in diff1 claim(s) had no matching evidence. Add the code, soften the
commit message, or annotate with
// allow-claim-miss: <symbol>and a reason.