fix(output): broken-anchor marker missing from find text output - #225
Merged
Conversation
…s' links section The nested links: renderer in build_file_object_filter had its own jq template that ignored fragment/broken_anchor, so `find --broken-links` text output showed anchored links as plainly resolved — contradicting the iter-190 CHANGELOG claim (which held only for the standalone LinkInfo filters). Template now appends #fragment and (broken anchor), kept in sync with LINK_INFO_ANCHORED_FILTER; e2e asserts the text path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find --broken-linkstext output rendered anchored links as plainly resolved: the nestedlinks:section inbuild_file_object_filterhas its own jq template, which iter-190 (PR feat(links): broken-anchor detection in find --broken-links (iter-190, L-21) #224) did not update — only the standalone LinkInfo filters got the anchor rendering, so the CHANGELOG's text-output claim was false on the path users actually see.#fragmentto the target and(broken anchor)after the path, matchingLINK_INFO_ANCHORED_FILTER.anchor_text_output_marks_broken_anchor) asserts the text path — the existing 9 anchor e2e only asserted JSON, which is how this slipped through.Test plan
(unresolved)with fragment shown"Foo#Nope" → "Foo.md" (broken anchor)🤖 Generated with Claude Code