Skip to content

stat_tracking: fix AttributeError on second update() call caused by in-place np.stack overwrite #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dev-X25874 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

stat_tracking: fix AttributeError on second update() call caused by in-place np.stack overwrite #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions flow_grpo/flow_grpo/stat_tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ def update(self, prompts, rewards, type='grpo'):
self.stats[prompt].extend(prompt_rewards)
self.history_prompts.add(hash(prompt)) # Add hash of prompt to history_prompts
for prompt in unique:
self.stats[prompt] = np.stack(self.stats[prompt])
prompt_history = np.array(self.stats[prompt])
prompt_rewards = rewards[prompts == prompt] # Fix: Recalculate prompt_rewards for each prompt
mean = np.mean(self.stats[prompt], axis=0, keepdims=True)
mean = np.mean(prompt_history, axis=0, keepdims=True)
if self.global_std:
std = np.std(rewards, axis=0, keepdims=True) + 1e-4 # Use global std of all rewards
else:
std = np.std(self.stats[prompt], axis=0, keepdims=True) + 1e-4
std = np.std(prompt_history, axis=0, keepdims=True) + 1e-4
if type=='grpo':
advantages[prompts == prompt] = (prompt_rewards - mean) / std
elif type=='rwr':
Expand Down Expand Up @@ -75,4 +75,4 @@ def main():
print("Stats after clear:", tracker.stats)

if __name__ == "__main__":
main()
main()