Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
README.md"How lorepy works" to state lorepy fits scikit-learn's defaultLogisticRegression()(L2,C=1.0) unless a custom classifier is provided, that class probabilities are computed via the softmax formula and evaluated at 200 evenly spacedxpoints, that confounders are included during fitting and then fixed to user-specified reference values at prediction time (i.e., curves are conditional on those reference values), and to clarify how sample dots are generated.Testing
python -m pytest -q, but the run aborted due to a missing dependency (ModuleNotFoundError: No module named 'numpy'), so automated tests could not be executed in this environment.Codex Task