Launch native Linux KeeperFX directly instead of via Wine#119
Merged
Conversation
KeeperFX now ships native Linux builds (the executable is 'keeperfx', no .exe). On Linux, Unearth previously always wrapped the game in Wine and only recognized keeperfx.exe, so Save & Play failed against a native install. All changes are guarded so Windows behavior is unchanged: - keeperfx_is_installed(): also accept an extension-less 'keeperfx'. - cmdline(): on X11, run the executable directly when it is not a .exe; keep using Wine for an actual .exe (Windows build under Wine). - auto_detect_executable(): detect a native 'keeperfx' binary in addition to keeperfx.exe / keeper.exe. - ChooseDkExe: on X11, clear the *.exe-only filter so the native binary is selectable in the file dialog. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
|
Looks good, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Linux launch for KeeperFX (no Wine)
KeeperFX now ships native Linux builds — the game executable is
keeperfxwith no.exeextension. On Linux, Unearth currently always wraps the game in Wine and only recognizeskeeperfx.exe, so Save & Play fails against a native KeeperFX install. This PR makes Save & Play work natively on Linux.All changes are guarded so Windows behavior is unchanged:
Game.gdkeeperfx_is_installed()— also accept an extension-lesskeeperfx.Game.gdcmdline()— on X11, run the executable directly when it is not a.exe(native binary); keep Wine for an actual.exe(Windows build under Wine).Settings.gdauto_detect_executable()— detect a nativekeeperfxbinary (no extension) in addition tokeeperfx.exe/keeper.exe.ChooseDkExe.gd— on X11, clear the*.exe-only file-dialog filter so the native binary is selectable.Testing
On Linux against a native KeeperFX build: auto-detect finds the native
keeperfx, the editor opens straight to editing (no “select executable” nag), andcmdline()producescd '<dir>' && './keeperfx' -level N -campaign X— verified that command launches the native game directly, no Wine.