Potential fix for code scanning alert no. 53: Client-side cross-site scripting#579
Merged
Potential fix for code scanning alert no. 53: Client-side cross-site scripting#579
Conversation
…scripting Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
The CodeQL autofix introduced sanitizeRepoPrStatsData but mapped
aiDetails to {label, count} instead of the required RepoPrDetail
shape {number, title, url, aiType, role}, causing a TS2352 type
error and CI build failure.
Replace the incorrect mapping with proper sanitization:
- number: coerced to safe non-negative number
- title: HTML-escaped string
- url: validated to http/https via toSafeHttpUrl
- aiType: constrained to allowed union values, fallback 'other-ai'
- role: constrained to allowed union values, fallback 'author'
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/rajbos/github-copilot-token-usage/security/code-scanning/53
Best fix: validate and sanitize the incoming
repoPrStatsDataat the message boundary before storing/rendering it, and ensure all dynamic fields used in HTML templates are escaped or type-coerced to safe primitives.In this file (
vscode-extension/src/webview/usage/main.ts), the least disruptive, functionality-preserving fix is:sanitizeRepoPrStatsDatafunction that:owner,repo,error, AI detail labels),repoPrStatsLoadedmessage case, sanitizemessage.databefore assigning torepoPrStatsDataand rendering.renderReposPrContent, ensure numeric outputs are explicitly formatted from safe numbers (defense in depth).This keeps existing UI behavior while eliminating tainted raw values flowing into
innerHTML.Suggested fixes powered by Copilot Autofix. Review carefully before merging.