Add provinces, dynasties, religions, holdings and expand alive data#19
Draft
clemux wants to merge 5 commits into
Draft
Add provinces, dynasties, religions, holdings and expand alive data#19clemux wants to merge 5 commits into
clemux wants to merge 5 commits into
Conversation
nickbabcock
reviewed
May 27, 2023
| #[derive(Debug, Deserialize)] | ||
| pub struct Holding { | ||
| pub r#type: Option<String>, | ||
| pub buildings: Vec<Building>, |
Contributor
There was a problem hiding this comment.
There are some saves that omit buildings, and my guess is that paradox often excludes fields that are empty or their default values, so I tend to prefer to use #[serde(default)] and not use Option too much unless there is a difference between empty/0 and None in game.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll leave this a draft for now, because I haven't written any tests, and I'm not sure about what fields should be
Option.I've tested it on a single save with 0 playtime, with the 1.9 patch, and it works with this thing I patched together