Pass the full JWT to the search endpoint for datagateway-search#1968
Open
xkyue wants to merge 3 commits into
Open
Pass the full JWT to the search endpoint for datagateway-search#1968xkyue wants to merge 3 commits into
xkyue wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1968 +/- ##
========================================
Coverage 96.72% 96.72%
========================================
Files 221 221
Lines 31463 31465 +2
Branches 4751 4751
========================================
+ Hits 30434 30436 +2
+ Misses 1025 1024 -1
- Partials 4 5 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
louise-davies
left a comment
louise-davies
left a comment
Member
There was a problem hiding this comment.
LGTM - @Reillyhewitson does this look suitable for what your API will require?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass the full JWT token and fixed some test new changes broke.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #1954