Bug/instrument name #1732

[xkyue]

Description

Ensure we are using instrument.fullName not instrument.name for ISIS

Testing instructions

Add a set up instructions describing how the reviewer should test the code

• Review code
• Check Actions build
• Review changes to test coverage

Agile board tracking

closes #1732

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.72%. Comparing base (d87046a) to head (b322ac5).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1969   +/-   ##
========================================
  Coverage    96.72%   96.72%           
========================================
  Files          221      221           
  Lines        31463    31467    +4     
  Branches      4751     4754    +3     
========================================
+ Hits         30434    30438    +4     
+ Misses        1025     1024    -1     
- Partials         4        5    +1     

Flag	Coverage Δ
common	95.48% <ø> (ø)
dataview	98.50% <100.00%> (+<0.01%)	⬆️
download	96.87% <ø> (ø)
search	95.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[xkyue]

Hi @louise-davies, I've noticed the name for the instrument on the breadcrumb is also the shorthand instead of the full name. Would you want that to be changed as well?

[louise-davies]

Hi @louise-davies, I've noticed the name for the instrument on the breadcrumb is also the shorthand instead of the full name. Would you want that to be changed as well?

@xkyue yes that would be good too, thanks for spotting it