Taskbar Music Lounge v4 #2856
Taskbar Music Lounge v4 #2856
Conversation
A sleek, pill-shaped music ticker for your Windows 11 taskbar. It sits unobtrusively in the corner, scrolling your current track and providing quick media controls.
Code Refactor: - Relies on windhawk process instead of direct injection - Added theme support
Added DWM and GSMTC Implementation for Win11
* Replaced the topmost timer with notification Z-Band usage. Made the mod target explorer.exe and not windhawk.exe for it to work. * Fixed the process failing to exit by clearing g_SessionManager in the right thread. * Reverted to the original Windhawk tool mod code (mostly formatting and logs).
Major update: Comprehensive fixes for v4 This version addresses and incorporates multiple suggestions. A detailed diff table has been added to the README. Addressed Issues & Fixes: * [#3666395914](ramensoftware#2746 (comment)) * [#3666527577](ramensoftware#2746 (comment)) * [2eddf69](ramensoftware@2eddf69#commitcomment-173045991) * [#3671818092](ramensoftware#2746 (comment)) * [ramensoftware#2828](ramensoftware#2828) * [#3689038965](ramensoftware#2746 (comment)) * [#3690241518](ramensoftware#2746 (comment)) Credits: Special thanks to @Cinabutts and @Deykii for code references and the community for testing. Testing Note: AIMP and MPC-BE integration is implemented but currently untested. Please report any issues with these players.
| } | ||
|
|
||
| if (!foundActive) { | ||
| session = g_SessionManager.GetCurrentSession(); |
There was a problem hiding this comment.
The GetCurrentSession documentation says: "This is the session the system believes the user would most likely want to control". Were they actually returning a paused while another session is playing? If not, I believe using it should have a better result than just picking the first playing session.
| DWORD pid = 0; | ||
| DWORD tid = GetWindowThreadProcessId(hTaskbar, &pid); | ||
| if (tid != 0) { | ||
| g_TaskbarHook = SetWinEventHook( |
There was a problem hiding this comment.
What happens if explorer is restarted? You might want to handle it (and make sure other things work) by handling the "TaskbarCreated" message:
https://learn.microsoft.com/en-us/windows/win32/shell/taskbar#taskbar-creation-notification
BTW how was it implemented? Some players require plugins to be compatible with GSMTC, see: You might want to add some information about this, and that link, to the mod readme. |
I created a volume adjustment that adjusts the player volume instead of the system volume when you hover your mouse over it. If you'd like, I can share it. |
|
Thank you so much for your work on this mod. I just wanted to mention some minor bugs in case it's possible to fix them in this PR.
|
|
Hi there @Hashah2311, I added this small functionality which completely hides the player when no music is playing, aka when booting up the PC for example. That way, the media player only shows when media is actually playing. https://www.diffchecker.com/BJHu5EUq/ Sorry that I sent this exact message also on your V3 PR not realizing that you already did one for v4 |
|
@zoombrzoom Ya ever gonna release your volume adjustment version? Looks good. I'd like to be able to place it in my own version. |
|
Can you add an option to hide the border ? |
|
Major update on my end if anyone wants to test it out, it's got practically every feature one would need. Still has some quirks to work out. |
7 participants
Major update: Comprehensive fixes for v4
This version addresses and incorporates multiple suggestions. A detailed diff table has been added to the README.
Addressed Issues & Fixes:
Credits:
Special thanks to @Cinabutts and @Deykii for code references and the community for testing.
Testing Note:
AIMP and MPC-BE integration is implemented but currently untested. Please report any issues with these players.