sheet.php: GAME_TITLE and navigation fixes - #13
Conversation
…name, and game-title id set for request email use.
…e home page. Improved feedback on invalid email address entry, error sending message and success.
|
We've (with @dougbinks) also fixed the mail validation script for the standard installation. Also added some error handling and user feedback. |
|
These are great fixes, please pull them asap. |
|
It looks like @Dearon has made a change (7416a50) which fixes one of the issues we fixed (mail) after we made this pull request. So this pull request won't merge without conflicts. We could do the work needed to integrate @daeron's change with our other fixes but only if there's some chance that @ramiismail thinks this is worthwhile doing (this would also allow us to submit a merge request for the google app engine integration). Alternatively @ramiismail can cherry pick the two game page fixes. |
|
@juliettef Yeah, I fixed them after askin Rami if there is something specific he wanted to see fixed. Your best bet to get things merged is to keep poking him on a regular basis, it's not ideal but it has worked for me so far :) |
|
Closing this pull request due to conflict (mail). |
Fixes to the projects pages (sheet.php) correct the following: