feat: integrate Rabbitizer via FetchContent#30
Closed
Lucasnribeiro wants to merge 2 commits intoran-j:mainfrom
Closed
feat: integrate Rabbitizer via FetchContent#30Lucasnribeiro wants to merge 2 commits intoran-j:mainfrom
Lucasnribeiro wants to merge 2 commits intoran-j:mainfrom
Conversation
ran-j
requested changes
Jan 29, 2026
Owner
|
Nice work @Lucasnribeiro |
Lucasnribeiro
force-pushed
the
rabbitizer-pr
branch
from
4d2caa3 to
a35f585
Compare
Contributor
Author
|
at first the idea was to just introduce rabbitizer, but i realized that we have the opportunity to just drop R5900_decoder entirely in favor of using Rabbitizer. Now the pr is a little bigger but more complete |
ran-j
requested changes
Jan 30, 2026
| std::cerr << "Error decoding instruction at " << formatAddress(addr) | ||
| << ": " << e.what() << std::endl; | ||
| } | ||
| RabbitizerInstruction instr; |
Owner
There was a problem hiding this comment.
Why not use decodeInstruction function here ?
| } | ||
|
|
||
| Instruction inst = m_decoder->decodeInstruction(address, rawInstruction); | ||
| Instruction inst = decodeInstruction(address, rawInstruction); |
Owner
There was a problem hiding this comment.
create a namespace for decoder so de can call decoder::decodeInstruction or some other namespace, insted of just calling decodeInstruction
| @@ -0,0 +1,651 @@ | |||
| #include "ps2recomp/decoder.h" | |||
Owner
There was a problem hiding this comment.
about this file: r5900_decoder.cpp functions lilke decodeIType, decodeRegimm and other handle way more that what we have here. why remove the other cases ?
Owner
|
migrate to #40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementing this issue #17