Solve issue #70: return full text article#96
Open
supercoder-dev wants to merge 1 commit into
Open
Conversation
holygeek00
approved these changes
Jul 25, 2024
holygeek00
left a comment
There was a problem hiding this comment.
Thank you for your contribution to solving issue #70 by returning the full text of the article. The changes are heading in the right direction. Here are a few suggestions to improve the implementation:
Documentation Update:
The docstring for the get_full_article method needs to be updated to reflect the new behavior accurately. The current docstring mentions returning an Article object, but now the method returns the full text of the article.
Error Handling:
When the article text is less than 200 characters, the function attempts to use BeautifulSoup to parse the HTML. It's a good approach, but we should add a check to ensure that article.html is not None before parsing.
ranahaani
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.