Repository navigation
Sprint 2.3: Migrate EnhancedIrView to Design System - #18
Merged
Merged
Conversation
Remove all 20+ inline styles and 4 CSS style objects, replacing with design system components: EnhancedIrView Changes: - Removed all CSS style objects (collapsibleStyle, summaryStyle, chipStyle, assistPanelStyle) - Main wrapper → Card with CardHeader, CardTitle, CardDescription, CardContent - Source selector → Button group with proper spacing - Session selector → Select component (replaced native select) - Session status → Card with Badge components and Separator - Loading/error states → Alert components with proper icons - IR sections → Card components with details/summary pattern - Section headers → ChevronDown icon with transition - Hole badges → Badge with warning variant - Typed hole chips → Button with rounded-full class - Session holes → Nested Card with border-warning styling - Hole resolution → Input component with proper structure - Assist panel → Card with CardHeader and CardContent - Intent/Signature/Effects/Assertions → Proper text sizing and spacing classes Design System Improvements: - AlertCircle, ChevronDown icons from lucide-react - Select component for session picker (replaced native select) - Proper Badge variants (warning, info, secondary, outline) - Card nesting for visual hierarchy - Consistent spacing (space-y-*, gap-*) - List styling with list-disc list-inside - Text sizing with text-sm, text-xs - Opacity classes for muted content - Border styling with border-warning - Background with bg-warning/5, bg-accent/90, bg-muted/50 Result: 0 inline styles, 0 CSS objects, 100% design system usage Bundle Impact: - EnhancedIrView chunk: 11.94 kB (3.86 kB gzipped) - vendor-radix increased to 96.78 kB (added Select component) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
8 tasks done
rand
added a commit
that referenced
this pull request
Oct 20, 2025
Remove all 20+ inline styles and 4 CSS style objects, replacing with design system components: EnhancedIrView Changes: - Removed all CSS style objects (collapsibleStyle, summaryStyle, chipStyle, assistPanelStyle) - Main wrapper → Card with CardHeader, CardTitle, CardDescription, CardContent - Source selector → Button group with proper spacing - Session selector → Select component (replaced native select) - Session status → Card with Badge components and Separator - Loading/error states → Alert components with proper icons - IR sections → Card components with details/summary pattern - Section headers → ChevronDown icon with transition - Hole badges → Badge with warning variant - Typed hole chips → Button with rounded-full class - Session holes → Nested Card with border-warning styling - Hole resolution → Input component with proper structure - Assist panel → Card with CardHeader and CardContent - Intent/Signature/Effects/Assertions → Proper text sizing and spacing classes Design System Improvements: - AlertCircle, ChevronDown icons from lucide-react - Select component for session picker (replaced native select) - Proper Badge variants (warning, info, secondary, outline) - Card nesting for visual hierarchy - Consistent spacing (space-y-*, gap-*) - List styling with list-disc list-inside - Text sizing with text-sm, text-xs - Opacity classes for muted content - Border styling with border-warning - Background with bg-warning/5, bg-accent/90, bg-muted/50 Result: 0 inline styles, 0 CSS objects, 100% design system usage Bundle Impact: - EnhancedIrView chunk: 11.94 kB (3.86 kB gzipped) - vendor-radix increased to 96.78 kB (added Select component) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sprint 2.3 checkpoint: Successfully migrated EnhancedIrView, the most complex view with 20+ inline styles and advanced interaction patterns.
🎯 Progress Checkpoint
Views Migrated: 5/9 (56%)
Remaining: 3 views (44%)
Inline Styles Removed: ~90/140 (64%)
✅ Sprint 2.3: EnhancedIrView Migration
Removed
collapsibleStyle,summaryStyle,chipStyle,assistPanelStyleAdded Components
<select>)Key Features Migrated
Design Patterns
Performance
EnhancedIrView:
Bundle Changes:
Testing
Files Changed
frontend/src/views/EnhancedIrView.tsx- Migrated (461 lines)Design System Consistency
All migrated views now share:
Next Steps (Final Sprint)
Continue with remaining 3 views:
Target: 100% design system adoption (9/9 views)
🤖 Generated with Claude Code