Skip to content

Hotfix/add webpack execution test #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diguin wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Hotfix/add webpack execution test #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
00d773b
Sf4 support
mastercoding Jan 16, 2018
9d8bd28
Webpack fixes
mastercoding Jan 16, 2018
32a3b3e
Yarn install
mastercoding Jan 16, 2018
5885d50
Webpack build with environment check
diguin Feb 21, 2018
9fa15ed
Merge pull request #1 from randock/webpack_build_depends_on_environment
mastercoding Feb 21, 2018
27327c6
Get access to environment variables
diguin Feb 21, 2018
a763755
Merge pull request #2 from randock/hotfix/get_access_to_environment_v…
diguin Feb 21, 2018
5dc0e44
php version
mastercoding Mar 31, 2018
1e17a13
Merge branch 'symfony4' of github.com:randock/build into symfony4
mastercoding Mar 31, 2018
4e34b0e
Add webpack execution for test environment
diguin Sep 13, 2018
6943507
Add symfony test condition
diguin Sep 13, 2018
803562b
Fix web pack test
diguin Sep 13, 2018
c1c4e3b
Merge pull request #5 from randock/hotfix/php-cs-fixer-3
mastercoding Feb 20, 2019
2a84d33
Merge branch 'symfony4' into hotfix/add_webpack_execution_test
jjpastor3 Feb 25, 2019
9d4bac5
Merge branch 'hotfix/phpqa-speed' into symfony4
mastercoding Jun 11, 2019
fef2744
Merge branch 'symfony4' of github.com:randock/build into symfony4
mastercoding Jun 11, 2019
24676bc
Merge pull request #7 from randock/symfony4
DavidGonzalezGutierrez Jul 12, 2019
d057237
Merge branch 'develop' into hotfix/add_webpack_execution_test
jjpastor3 Apr 23, 2020
2995d56
Merge branch 'hotfix/add_webpack_execution_test' of github.com:randoc…
jjpastor3 Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions build.lint.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,62 +11,62 @@
depends="lint-twig,lint-yml"
description="Performs static analysis" />

<!-- This executes the PHP internal linter (php -l) -->
<!-- This executes the PHP internal linter (php -l) -->
<target name="lint-php"
unless="lint-php.done"
description="Perform syntax check of sourcecode files">
<apply executable="php" taskname="lint" failonerror="true">
<arg value="-l" />
<apply executable="php" taskname="lint" failonerror="true">
<arg value="-l" />

<fileset dir="${basedir}/src" errorOnMissingDir = "false">
<include name="**/*.php" />
</fileset>
<fileset dir="${basedir}/src" errorOnMissingDir = "false">
<include name="**/*.php" />
</fileset>

<fileset dir="${basedir}/tests" errorOnMissingDir = "false">
<include name="**/*.php" />
</fileset>
<fileset dir="${basedir}/tests" errorOnMissingDir = "false">
<include name="**/*.php" />
</fileset>

<fileset dir="${basedir}/app" errorOnMissingDir = "false">
<include name="**/*.php" />
</fileset>
<fileset dir="${basedir}/app" errorOnMissingDir = "false">
<include name="**/*.php" />
</fileset>

</apply>
</apply>

<property name="lint-php.done" value="true"/>
<property name="lint-php.done" value="true"/>
</target>

<!-- Executes the symfony provided twig linter -->
<!-- Executes the symfony provided twig linter -->
<target name="lint-twig"
unless="lint-twig.done"
description="Perform syntax check of twig files"
depends="-check-symfony-console"
if="symfony-console.exists">
<apply executable="${symfony-console}" taskname="lint-twig" failonerror="true">
<arg value="lint:twig" />
<dirset dir = "${basedir}">
<include name="app" />
<include name="src" />
</dirset>
</apply>
<apply executable="${symfony4-console}" taskname="lint-twig" failonerror="true">
<arg value="lint:twig" />
<dirset dir = "${basedir}">
<include name="app" />
<include name="src" />
</dirset>
</apply>

<property name="lint-twig.done" value="true"/>
<property name="lint-twig.done" value="true"/>
</target>

<!-- Executes the symfony provided yaml linter -->
<!-- Executes the symfony provided yaml linter -->
<target name="lint-yml"
unless="lint-yml.done"
description="Perform syntax check of yml files"
depends="-check-symfony-console"
if="symfony-console.exists">
<apply executable="${symfony-console}" taskname="lint-yml" failonerror="true">
<arg value="lint:yaml" />
<dirset dir = "${basedir}">
<include name="app" />
<include name="src" />
</dirset>
</apply>
<apply executable="${symfony4-console}" taskname="lint-yml" failonerror="true">
<arg value="lint:yaml" />
<dirset dir = "${basedir}">
<include name="app" />
<include name="src" />
</dirset>
</apply>

<property name="lint-yml.done" value="true"/>
<property name="lint-yml.done" value="true"/>
</target>

</project>
2 changes: 1 addition & 1 deletion build.phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<!-- We define the paths to the executables here, for easier
modification -->
<property name="phpunit" value="${basedir}/vendor/bin/phpunit"/>
<property name="phpunit" value="${basedir}/vendor/bin/simple-phpunit"/>

<!-- Check if composer is available -->
<target name="check-phpunit">
Expand Down
5 changes: 2 additions & 3 deletions build.symfony.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<project name="randock.symfony">
<import file="./build.symfony3.xml" />
<import file="./build.symfony4.xml" />

<target name="symfony-prepare" depends="symfony3-prepare,symfony4-prepare" />
<target name="symfony-prepare" depends="symfony4-prepare" />

<target name="symfony-change-owner"
depends="symfony3-change-owner,symfony4-change-owner" />
depends="symfony4-change-owner" />

</project>
45 changes: 0 additions & 45 deletions build.symfony3.xml
View file
Open in desktop

This file was deleted.

57 changes: 54 additions & 3 deletions build.symfony4.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,76 @@
<!-- symfony console location -->
<property name="symfony4-console" value="bin/console" />
<property name="yarn" value="/usr/bin/yarn" />
<property environment="env"/>

<!-- Check if symfony is available -->
<target name="symfony4-check">
<available file="${yarn}" property="symfony4.available" />
<available file="${symfony4-console}" property="symfony4.available" />
</target>

<!-- Check if yarn is available -->
<target name="yarn-check">
<available file="${yarn}" property="yarn.available" />
</target>
<target name="symfony4-prepare"
depends="symfony4-check"
if="symfony4.available">
<antcall target= "symfony4-schema:update" />
<antcall target= "symfony4-webpack:build" />
<antcall target= "symfony4-change-owner" />
</target>

<target name="symfony4-webpack:build">
<antcall target="symfony4-webpack:build:prod-with-check"/>
<antcall target="symfony4-webpack:build:dev-with-check"/>
<antcall target="symfony4-webpack:build:test-with-check"/>
</target>

<target name="symfony4-webpack:build:prod-with-check" depends="symfony-environment-check" if="symfony.prod">
<antcall target="symfony4-webpack:build:prod"/>
</target>
<target name="symfony4-webpack:build:dev-with-check" depends="symfony-environment-check" if="symfony.dev">
<antcall target="symfony4-webpack:build:dev"/>
</target>
<target name="symfony4-webpack:build:test-with-check" depends="symfony-environment-check" if="symfony.test">
<antcall target="symfony4-webpack:build:dev"/>
</target>

<target name="symfony-environment-check">
<condition property="symfony.prod">
<equals arg1="${env.APP_ENV}" arg2="prod"/>
</condition>
<condition property="symfony.dev">
<equals arg1="${env.APP_ENV}" arg2="dev"/>
</condition>
<condition property="symfony.test">
<equals arg1="${env.APP_ENV}" arg2="test"/>
</condition>
</target>

<target name="symfony4-webpack:build:prod"
depends="yarn-check"
if="yarn.available">
<exec executable="${yarn}">
<arg value="install" />
</exec>
<exec executable="${yarn}">
<arg value="build" />
</exec>
</target>

<target name="symfony4-webpack:build:dev"
depends="yarn-check"
if="yarn.available">
<exec executable="${yarn}">
<arg value="install" />
</exec>
<exec executable="${yarn}">
<arg value="encore" />
<arg value="dev" />
</exec>
</target>

<target name="symfony4-schema:update">
<exec executable="${symfony4-console}">
<arg value="doctrine:schema:update" />
Expand All @@ -33,10 +84,10 @@
<target name="symfony4-change-owner"
depends="symfony4-check"
if="symfony4.available">
<exec executable="chmod">
<exec executable="chmod">
<arg value = "-R" />
<arg value = "0777" />
<arg value = "var" />
</exec>
</target>
</project>
</project>
6 changes: 3 additions & 3 deletions build.xdebug.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<!-- Disable xdebug for faster execution of some tasks-->
<target name = "xdebug-disable">
<exec executable="rm">
<arg value = "/etc/php/7.1/cli/conf.d/20-xdebug.ini" />
<arg value = "/etc/php/${php_version}/cli/conf.d/20-xdebug.ini" />
<arg value = "--force" />
</exec>
</target>
Expand All @@ -14,8 +14,8 @@
<antcall target = "xdebug-disable" />
<exec executable="ln">
<arg value = "-s" />
<arg value = "/etc/php/7.1/mods-available/xdebug.ini" />
<arg value = "/etc/php/7.1/cli/conf.d/20-xdebug.ini" />
<arg value = "/etc/php/${php_version}/mods-available/xdebug.ini" />
<arg value = "/etc/php/${php_version}/cli/conf.d/20-xdebug.ini" />
</exec>
</target>
</project>