Skip to content

Fix failing CI: remove deprecated runners, fix Qt6 WebEngine build - #88

Closed
randymarsh77 with Copilot wants to merge 2 commits into
masterfrom
copilot/wreck-it-fix-failing-checks
Closed

Fix failing CI: remove deprecated runners, fix Qt6 WebEngine build#88
randymarsh77 with Copilot wants to merge 2 commits into
masterfrom
copilot/wreck-it-fix-failing-checks

Conversation

Copilot AI commented Apr 2, 2026

Copy link
Copy Markdown

CI was broken by two independent issues: legacy jobs targeting removed GitHub runner images (ubuntu-20.04, macos-10.15, windows-2019), and a Qt6 build failure where QWebEnginePage moved from QtWebEngineWidgets to QtWebEngineCore.

official.yml

  • Drop legacy Qt 4.8 packaging jobs (ubuntu-20.04, macos-10.15, windows-2019 runners are gone/deprecated)
  • Add ci-qt-webkit job on ubuntu-24.04 with qt6-webengine-dev that builds/tests/lints with --features qt-webkit

crates/core/build.rs

  • Add .qt_module("WebEngineCore") — Qt6 moved QWebEnginePage/QWebEngineSettings out of QtWebEngineWidgets
  • Fix cxx-qt-build 0.8 API: .file() for the Rust bridge (qt_webkit.rs), .cpp_file() for the C++ impl
  • Add Gui and Widgets modules for QImage/QPixmap and QApplication
  • Wrap cc_builder call in unsafe as required by cxx-qt-build 0.8
cxx_qt_build::CxxQtBuilder::new()
    .file("src/qt_webkit.rs")
    .cpp_file("src/webkit_renderer.cpp")
    .cc_builder(|cc| { cc.include("include"); })
    .qt_module("Gui")
    .qt_module("Widgets")
    .qt_module("WebEngineCore")   // QWebEnginePage lives here in Qt6
    .qt_module("WebEngineWidgets")
    .build();

webkit_renderer.h / webkit_renderer.cpp

  • Add const to run_scripts parameter (rust::Slice<const rust::Str>) to match cxx-generated signature for &[&str]

Copilot AI changed the title [WIP] Fix failing CI checks on master Fix failing CI: remove deprecated runners, fix Qt6 WebEngine build Apr 2, 2026
Copilot AI requested a review from randymarsh77 April 2, 2026 04:47
@randymarsh77
randymarsh77 deleted the copilot/wreck-it-fix-failing-checks branch April 2, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wreck-it] unstuck [wreck-it] Fix failing checks on master

2 participants