Repository navigation
Deliver chunked rich-text copies (Excel) to the local clipboard - #38
Merged
Merged
Conversation
Copies with markup over ~16 KB arrive in chunks, and Selkies' chunked handler treated the markup-and-text bundle as an image, so it failed to decode and nothing reached the clipboard. Excel's HTML passes 16 KB for a few cells, so most Excel copies were lost. Handle the bundle there the way the single-message path does. Fixes #37 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37
What changed
New client patch 10 in
scripts/patch_selkies.py: the Selkies web client's chunked clipboard handler (clipboard_finish) now handles theapplication/x-selkies-clipboard-flavoursbundle the same way the single-message path does — unpack it, record its signature, and write HTML + text to the local clipboard. Before, the bundle went down the image path, failed to decode, and nothing was written. The server splits payloads over ~16 KB, and Excel's HTML exceeds that for even a few cells.Testing
pytest: 227 passed, 3 skipped. The test stand-in now carries the realclipboard_finishhandler verbatim and runs it in Node: a chunked Excel-sized bundle is written as markup with the patch and fails without it; chunked plain text is unchanged.selkies-core.jsfrom the deployed container; the bundle parses (node --check).🤖 Generated with Claude Code