Repository navigation
Refuse to overwrite a profiles.json that can't be read - #40
Merged
Merged
Conversation
An unreadable profiles.json listed as no profiles, and the next save or delete wrote that empty list back over it, losing every saved profile. Saving and deleting now fail with an error instead, so the file can be fixed or restored first; listing still shows no profiles. Fixes #39 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
What changed
load_profiles(for_update=True)raises a 500 ("…/profiles.json is unreadable; fix or restore it before saving profiles") instead of returning[]when the file can't be parsed or isn't a list.save_profile()andremove_profile()use it, so they no longer write an empty list over a damaged file.GET /api/profiles) and connecting keep the old behaviour: a damaged file shows as no profiles and is logged.Testing
pytest: 229 passed, 3 skipped. New API tests: a truncated file lists as empty; save and delete return 500 and leave the file byte-for-byte unchanged; a non-list JSON file counts as damaged; a missing file is still created on first save. Three of them fail without the fix.🤖 Generated with Claude Code