forked from chamburr/glance
-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate preview rendering and parsers to Rust #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
355e533
feat: replace HTML rendering with Rust
ranokay 21d9f23
feat: move preview parsers to Rust
ranokay b718e74
chore: prepare 1.6.0 release
ranokay 026c9d9
fix: install Rust lint components in CI
ranokay ce271eb
fix: address preview migration review findings
ranokay d38fcae
fix: address production review findings
ranokay 56bbc15
fix: authenticate CI tool downloads
ranokay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| name: Production Verification | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: verify-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| verify: | ||
| name: Rust, Xcode, and release gates | ||
| runs-on: macos-26 | ||
| timeout-minutes: 45 | ||
|
|
||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Assert macOS 26 Apple Silicon toolchain | ||
| run: | | ||
| set -euo pipefail | ||
| test "$(uname -m)" = "arm64" | ||
| test "$(sw_vers -productVersion | cut -d. -f1)" = "26" | ||
| test "$(xcodebuild -version | awk 'NR == 1 { split($2, version, "."); print version[1] }')" = "26" | ||
|
|
||
| - name: Install checksum-verified mise | ||
| run: | | ||
| set -euo pipefail | ||
| MISE_VERSION="2026.6.0" | ||
| MISE_TARBALL="mise-v${MISE_VERSION}-macos-arm64.tar.gz" | ||
| curl -fsSLO "https://github.com/jdx/mise/releases/download/v${MISE_VERSION}/${MISE_TARBALL}" | ||
| echo "8830cf720025583bfbc5ca77bcf15958bf6efb4743fb84be6b572fd85d3a6cd0 ${MISE_TARBALL}" | shasum -a 256 -c - | ||
| tar -xzf "$MISE_TARBALL" | ||
| mkdir -p "$HOME/.local/bin" | ||
| cp mise/bin/mise "$HOME/.local/bin/mise" | ||
| echo "$HOME/.local/bin" >> "$GITHUB_PATH" | ||
|
|
||
| - name: Install pinned tools | ||
| env: | ||
| GITHUB_TOKEN: ${{ github.token }} | ||
| MISE_YES: "1" | ||
| run: | | ||
| set -euo pipefail | ||
| mise trust mise.toml | ||
| mise install | ||
| mise exec -- rustup component add rustfmt clippy | ||
|
|
||
| - name: Run production verification | ||
| run: | | ||
| set -euo pipefail | ||
| mise run verify | ||
| mise run verify:app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,9 @@ | ||
| # Xcode | ||
| project.xcworkspace/ | ||
| !Glance.xcodeproj/project.xcworkspace/ | ||
| !Glance.xcodeproj/project.xcworkspace/xcshareddata/ | ||
| !Glance.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/ | ||
| !Glance.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved | ||
| xcuserdata/ | ||
| build/ | ||
| .DS_Store | ||
|
|
||
| # `go build` output | ||
| HTMLConverter/htmlconverter*.a | ||
| HTMLConverter/htmlconverter*.h | ||
| # Rust build output | ||
| PreviewCore/build/ | ||
| PreviewCore/target/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.