Skip to content

Fix loop termination bug in Tutorial 07 (Code + Docs) #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Agents-swarm-it wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix loop termination bug in Tutorial 07 (Code + Docs) #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94bd1bf
Fix: Use escalate to properly terminate loop in agent.py
Agents-swarm-it Jan 19, 2026
3251a8a
Fix: Update tutorial docs to match correct termination logic
Agents-swarm-it Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/docs/07_loop_agents.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def exit_loop(tool_context: ToolContext):
Called by the refiner when critic approves the essay.
"""
print(f" [Exit Loop] Called by {tool_context.agent_name} - Essay approved!")
tool_context.actions.end_of_agent = True # Signal to stop looping
tool_context.actions.escalate = True # Signal to stop looping
# Return a minimal valid content part so the backend always produces a valid LlmResponse
return {"text": "Loop exited successfully. The agent has determined the task is complete."}

Expand Down
4 changes: 2 additions & 2 deletions tutorial_implementation/tutorial07/essay_refiner/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def exit_loop(tool_context: ToolContext):
Called by the refiner when critic approves the essay.
"""
print(f" [Exit Loop] Called by {tool_context.agent_name} - Essay approved!")
tool_context.actions.end_of_agent = True # Signal to stop looping
tool_context.actions.escalate = True # Signal to stop looping
# Return a minimal valid content part so the backend always produces a valid LlmResponse
return {"text": "Loop exited successfully. The agent has determined the task is complete."}

Expand Down Expand Up @@ -126,4 +126,4 @@ def exit_loop(tool_context: ToolContext):
)

# MUST be named root_agent for ADK
root_agent = essay_refinement_system
root_agent = essay_refinement_system