Restore titlebar double-click with hidden tab strip - #1867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes and closes #1866 by @jxdones, keeping their commit. The original fix is right: on macOS with hide-if-single, the full-size content view keeps the top band as custom window chrome (padding_top_from_config reserves ISLAND_HEIGHT whenever Tab navigation is enabled), so clicks there belong to the window drag and double-click handler, not the grid.
On top of it, the two review notes applied:
The chrome-band predicate now lives in one place.
Navigation::chrome_band_reservedencodes "macOS reserves the band whenever Tab navigation is enabled, other platforms only while the island is painted", and both input layers (the cursor override in application.rs, the click routing in screen/mod.rs) call it instead of re-deriving the condition. It must agree with padding_top_from_config, and the doc comment plus a unit test pin that contract.Right-clicks in the hidden band are consumed like the visible island's chrome regions instead of falling through to the grid, where they acted on the first terminal row while the pointer was over window chrome.
The UCRT64 failure on the original PR was our CI lane building workspace cdylibs in debug, which exceeds the PE export-ordinal limit on windows-gnu; fixed on main and this branch includes it.