This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fixed missing argument to factory closure which caused window to be null in IE10#30
Open
auchenberg wants to merge 2 commits intorapid7:masterfrom
Open
Fixed missing argument to factory closure which caused window to be null in IE10#30auchenberg wants to merge 2 commits intorapid7:masterfrom
auchenberg wants to merge 2 commits intorapid7:masterfrom
Conversation
Fixed missing argument to factory closure which caused window to be null in IE10.
Contributor
|
@auchenberg thanks for this! It looks like the tests aren't happy for some reason so I'll fix them before I merge this. |
Author
|
Ahh. I see why. Since I'm now passing an argument to the closure, the function is executed and therefore not returning anything. Either the inner function should be wrapped in return function() {
// func
} or we simply should pass |
Contributor
|
@auchenberg Either way the tests should fail in their current state- we need to look into this first. |
This was referenced Nov 10, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed missing argument to factory closure which caused window to be null in IE10.
Exception thrown in IE: