This repository was archived by the owner on Mar 5, 2025. It is now read-only.
If window is available, prefer it over this#58
Open
blackbaud-brandonstirnaman wants to merge 1 commit intorapid7:masterfrom
Open
If window is available, prefer it over this#58blackbaud-brandonstirnaman wants to merge 1 commit intorapid7:masterfrom
blackbaud-brandonstirnaman wants to merge 1 commit intorapid7:masterfrom
Conversation
…k/browserify) still get the correct root in the browser
|
Hey guys, any luck with merging this fix in observable future? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that packagers (webpack/browserify) still get the correct root in the browser and can access window.location. Fixes #55 in a very simple way while maintaining the other logic for node.js global.