Adds additional support for network capture decryption#20115
Conversation
b721347 to
5b5ea2a
Compare
5b5ea2a to
c967e94
Compare
|
LGTM 👍 Tested out some of the login modules manually, and they did create the SSLKeyLogFile file with the CLIENT_RANDOM key or append to the file if it exists already with the SSL option enabled. Some that roll their own encryption algorithm like mssql and mysql weren't able to be decrypted in WireShark out of the box which is expected. |
|
Looks like @sjanusz-r7 forgot to merge this, but has given his official seal of approval that this is 100% perfect 🏆 |
Release NotesUpdates multiple HTTPS modules to support a new |
Note
I have updated the workflows for Postgres and LDAP to now be ran when changes are made to login scanner or TCP. In aim off avoiding what happened in #20114 were those were on ran once merged even those changes in the areas above caused the workflows to fail.
This PR combines #20114 and #20099. As #20114 was failing once merged and I decided to combine them together to make testing easier. Can be split again if preferred 👍
This pull request adds enhanced support for network capture decryption for http scanner modules as well as login scanner modules. By writing to the
sslkeylogfileit enables network capture decryption which is useful to decrypt TLS traffic in Wireshark.This is a follow on to #20024 and rapid7/rex-socket#74.
This pull request adds enhanced support for network capture decryption for login scanner modules. By writing to the
sslkeylogfileit enables network capture decryption which is useful to decrypt TLS traffic in Wireshark.This is a follow on to #20024, #20080 and rapid7/rex-socket#74.
I have also update the workflows for Postgres and LDAP to now be ran when changes are made to login scanner or TCP. In aim off avoiding what happened in #20114 were those were on ran once merged even those changes in the areas above caused the workflows to fail.
Testing
Tested against the following modules:
scanner/acpp/loginscanner/ftp/ftp_loginscanner/mysql/mysql_loginscanner/afp/afp_loginscanner/db2/db2_authscanner/mqtt/connectscanner/pop3/pop3_loginscanner/telnet/brocade_enable_loginscanner/telnet/telnet_loginscanner/vmware/vmauthd_loginscanner/vnc/vnc_loginscanner/mssql/mssql_loginAs well as testing completed previous here: #20080 (comment)
Verification
msfconsolescanner/*/*_loginmodules.ls -laand you should now see a file calledsslkeylogfile.txt