Merged
Conversation
sjanusz-r7
reviewed
Mar 6, 2025
zeroSteiner
force-pushed
the
feat/dcerpc/gkdi/1
branch
from
436b7d6 to
326f7e7
Compare
9 tasks
zeroSteiner
force-pushed
the
feat/dcerpc/gkdi/1
branch
from
326f7e7 to
2071a83
Compare
jheysel-r7
approved these changes
Apr 30, 2025
Contributor
jheysel-r7
left a comment
jheysel-r7
left a comment
There was a problem hiding this comment.
This has been tested successfully with rapid7/metasploit-framework#20017 and the structures being add have been compared to their specifications outlined on https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-gkdi/ and everything seems to be in working order 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few key MS-GKDI structures for interacting with the service. There's only one DCERPC method,
GetKey.These changes will be required by a PR to Metasploit at some point and it's probably best to wait for that to test the changes with the new module.