[2.x] Use localStorage for user data#1168
Merged
Merged
Conversation
Member
|
Related: #1066 |
Member
|
Do we also need the setTimeout? See: https://github.com/rapidez/core/pull/1066/changes |
Collaborator
Author
Not necessary but useful nonetheless. Will add. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: AN-394
My best explanation for the hard to reproduce login issues is that it's related to sessionStorage being cleared (for whatever reason). The only way that I was able to get a very similar error pattern was by manually clearing the user data out of the session storage.
As we've also made the user data part of localStorage in 4.x and 5.x, this is also the most logical fix.