Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Replace CUDA_TRY with CUSPATIAL_CUDA_TRY - #516

Merged
rapids-bot[bot] merged 4 commits into
rapidsai:branch-22.06from
isVoid:fix/update_cuda_try
Apr 13, 2022
Merged

Replace CUDA_TRY with CUSPATIAL_CUDA_TRY#516
rapids-bot[bot] merged 4 commits into
rapidsai:branch-22.06from
isVoid:fix/update_cuda_try

Conversation

@isVoid

@isVoid isVoid commented Apr 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Following NVIDIA/cudf#10589, this PR removes the dependency to cudf::CUDA_TRY and introduces CUSPATIAL_CUDA_TRY.

Contributes to #474

@isVoid
isVoid requested a review from a team as a code owner April 7, 2022 23:40
@isVoid
isVoid requested review from thomcom and zhangjianting April 7, 2022 23:40
@github-actions github-actions Bot added the libcuspatial Relates to the cuSpatial C++ library label Apr 7, 2022
@isVoid isVoid added improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Apr 7, 2022
@vyasr

vyasr commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

JFYI, #511 renamed all uses of CUDA_TRY outside of benchmarks to CUDF_CUDA_TRY, so you'll need to update those as well to remove the cudf dependence.

@isVoid

isVoid commented Apr 8, 2022

Copy link
Copy Markdown
Contributor Author

Ok thanks. I found an extra usage of CUDF_CUDA_TRY.

harrism
harrism approved these changes Apr 8, 2022
View reviewed changes

@harrism harrism left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really all of them? Thought there would be more.

@isVoid

isVoid commented Apr 8, 2022

Copy link
Copy Markdown
Contributor Author

#511 shows total 3 usage of CUDF_CUDA_TRY. There are 2 more usage of CUDF_CHECK_CUDA which still depends on libcudf. Should we also replace them?

@isVoid

isVoid commented Apr 13, 2022

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit c4700e6 into rapidsai:branch-22.06 Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zhangjianting zhangjianting Awaiting requested review from zhangjianting zhangjianting is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners
2 more reviewers
@thomcom thomcom thomcom approved these changes
@harrism harrism harrism approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isVoid @vyasr @thomcom @harrism