Add cuml ray hpo example#664
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ncclementi
left a comment
There was a problem hiding this comment.
Things to discuss
| "When running this notebook with a Conda environment, you may see messages like the following appear in your output while Ray hyperparameter trials are running:\n", | ||
| " \n", | ||
| "```\n", | ||
| "(raylet) I0000 00:00:1770938640.198717 34590 chttp2_transport.cc:1182] ipv4:10.128.0.35:33125: Got goaway [2]\n", |
There was a problem hiding this comment.
It's not clear to me why this happen, but things run successfully, so I left a note, it only happens on the conda install.
632ec90 to
2920c98
Compare
|
@jacobtomlinson I'm seeing quite a bit of issues with the build and deploy, that I don't see locally when building the docs. There is a warning, that seem to be treated as error, but it's not super clear which ones, I see Maybe this one, could be one? |
|
Thanks for this. I'll block out some time next week to review it thoroughly. I think this is the warning that's causing the CI to fail. It should probably be
|
|
Oh that was it, Thank you @jacobtomlinson |
| "````{tab-item} uv\n", | ||
| ":sync: uv\n", | ||
| "\n", | ||
| "1. Check Your CUDA Version in the Jupyter terminal\n", |
There was a problem hiding this comment.
Update: CuPy 14 was released. Now when installing cuml via uv pip in a system that does not have a system installation of cuda runtime, things work as expected. cuml is bringing the runtime with it, and cupy can find it successfully.
I tested things and had no problem.
9b33613 to
c8d8e90
Compare
| @@ -0,0 +1,560 @@ | |||
| { | |||
There was a problem hiding this comment.
Out if interest I installed the jupyter-server-proxy and tried to access the Ray dashboard at myinstance.brevlab.com/proxy/8265 but the page doesn't load because Ray is not working properly with the proxy. I might make a small reproducer and open it on Ray.
Reply via ReviewNB
There was a problem hiding this comment.
I haven't tried that, but it would be worth reporting this to Brev. I was accessing the Ray dashboard in the browser directly, and in that case the port-forward worked just fine.
|
@jacobtomlinson Thanks for the review, I think I cover all your suggestions. |
I wanted to push this because it's almost there, but there are some hiccups that I think will make the notebook more complicated if fix now, but we can wait a bit, and things will hopefully be easier.
Look at the comments in the review.
Ignore failing CI for now, I know it's broken :P
TODO:
Regarding,
I tried doing a
ray.putandray.getusing numpy arrays, I only noticed on the Ray dashboard that the object Store memory was ~ 0.5 smaller, ( 1GB vs 1.5 GB) that being said, this did not affect the time it took to run the 8 trials, so I decided not to complicate the notebook.Regarding
After a conversation with @jacobtomlinson we decided to document the path for both uv and conda, as is at the moment and when cupy 14 is out, simplify the
uvone. It's unclear when cupy 14 will be out yet.