Add more notebook datasets, test depth=16#155
Open
RAMitchell wants to merge 1 commit intorapidsai:mainfrom
Open
Add more notebook datasets, test depth=16#155RAMitchell wants to merge 1 commit intorapidsai:mainfrom
RAMitchell wants to merge 1 commit intorapidsai:mainfrom
Conversation
mfoerste4
reviewed
Sep 9, 2024
Contributor
mfoerste4
left a comment
There was a problem hiding this comment.
It is a bit hard to review these changes as the file is stored in git LFS. I have browsed over it and I have a couple of thoughts:
- This notebook has grown quite large. Would it be feasible to extract the utilities (data fetchers / runners) into a python module?
- I don't quite like the inclusions of graphs & performance numbers into the file that is checked in. These numbers are not auto-updated once we change the code and they are only valid for a certain hardware they were run on the last time someone modified the file. I would also prefer to not have the verbosity log all iterations into the notebook output. Maybe we should split it into a (small) notebook example with graphs and a larger benchmark comparison script (that can also output to csv?).
Contributor
Author
|
I'd rather not extract them at the moment but keep it a self contained example. The notebook is not that large as loading each dataset is only a few lines. I guess thats the problem with notebooks in general, but I still think its worth checking in even if it might go out of date. Agree with removing the verbosity output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #38