Skip to content

Correct CI failures building examples - #1080

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
robertmaynard:bug/ignore_rmm_deprecation_warnings
Aug 20, 2026
Merged

Correct CI failures building examples #1080
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
robertmaynard:bug/ignore_rmm_deprecation_warnings

Conversation

@robertmaynard

@robertmaynard robertmaynard commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

We are seeing failures in other PR's (#1079) due to CCCL deprecation warning becoming errors.

This exposed the fact that our PIN example wasn't being invoked using the proper CMake preset

@robertmaynard
robertmaynard requested a review from a team as a code owner August 20, 2026 13:33
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change labels Aug 20, 2026
@robertmaynard
robertmaynard force-pushed the bug/ignore_rmm_deprecation_warnings branch 2 times, most recently from 25c747d to 63fc5ec Compare August 20, 2026 14:17
@robertmaynard
robertmaynard requested a review from a team as a code owner August 20, 2026 14:17
@robertmaynard
robertmaynard force-pushed the bug/ignore_rmm_deprecation_warnings branch from 63fc5ec to 754c4c1 Compare August 20, 2026 14:49
@robertmaynard robertmaynard changed the title Disable cccl deprecation warnings in examples offline build Correct CI failures building examples Aug 20, 2026
@robertmaynard robertmaynard mentioned this pull request Aug 20, 2026
Merged
bdice
bdice reviewed Aug 20, 2026
View reviewed changes

@bdice bdice left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RMM has already fixed this upstream. Pulling a new RMM would also work here.

I am concerned that ignoring this warning is not really effective; updating RMM is probably less work. It also doesn't prevent future issues, because the ignore is so specific.

@robertmaynard

robertmaynard commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

RMM has already fixed this upstream. Pulling a new RMM would also work here.

I am concerned that ignoring this warning is not really effective; updating RMM is probably less work. It also doesn't prevent future issues, because the ignore is so specific.

Awesome that will allow me to drop the changes in examples/offline_build/use_offline_source_cache.sh. The PINS changes are all required as the testing wasn't actually testing the correct thing and was building using latest rmm/cccl instead of using the actual pin file.

@robertmaynard
robertmaynard force-pushed the bug/ignore_rmm_deprecation_warnings branch from 754c4c1 to 2aefa58 Compare August 20, 2026 16:37
@robertmaynard
robertmaynard requested a review from bdice August 20, 2026 17:25
@robertmaynard

robertmaynard commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 5060a89 into rapidsai:main Aug 20, 2026
18 checks passed
@robertmaynard
robertmaynard deleted the bug/ignore_rmm_deprecation_warnings branch August 20, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes
@jameslamb jameslamb jameslamb approved these changes
@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees

No one assigned

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robertmaynard @bdice @jameslamb