Forward-merge release/0.50 into main#654
Merged
Merged
Conversation
Add an opt-in mechanism for querying UCP request attributes (memory type, debug string) on every `ucxx::Request`. Enabled via a new `ucxx::experimental::WorkerBuilder::requestAttributes(true)` option. When enabled, every `ucxx::Request` submit site funnels through a small `Request::publishRequest()` helper that stores the UCP handle and queries `ucp_request_query` under the existing `_mutex`. `ucp_request_free` moves from `Request::callback` into `Request::setStatus`, making the query and the free mutually exclusive without any new atomics or callback-side locking. Wired through every request type and exposed to users via `Request::queryAttributes()`, which throws `ucxx::UnsupportedError` when the feature is disabled on the owning worker and `ucxx::NoElemError` when UCX took an inline path that produced no UCP handle to query (e.g., an eager UCX transfer). Tag, AM, and MemoryGet test are asserted strictly above the rendezvous threshold, where UCX deterministically allocates a queryable request on every transport. Stream and MemoryPut use lenient assertions (substring-check on success, throw is acceptable) because stream has no rendezvous protocol and small RMA puts are fire-and-forget, both of which have transport-dependent inline-completion behavior that no fixed size threshold can portably predict. The toggle is worker-scoped: enabling it queries attributes on **every** request created from that worker, which has potentially non-negligible per-request cost. Fine-grained per-request opt-in (so callers can attribute-query only the requests they care about) is not implemented here, it requires a builder-pattern constructor at the request level which doesn't exist yet, and is deferred to a follow-up. For now, users who need attributes accept the worker-wide cost, and users who don't, opt out by leaving the default. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Lawrence Mitchell (https://github.com/wence-) - Bradley Dice (https://github.com/bdice) URL: #437
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.50 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.