Fix/qrcode hardening#16
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69ae29fbeb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| DEFAULT_BG_COLOR = "#ffffff" | ||
| MIN_PIXEL_WIDTH = 1 | ||
| MAX_PIXEL_WIDTH = 100 | ||
| <<<<<<< Updated upstream |
There was a problem hiding this comment.
The <<<<<<< conflict marker committed in app/qrcoderesponse.py makes the module invalid Python, so importing qrcoderesponse raises a SyntaxError and the app cannot start (including /qr handling and tests that import this module). This is a release-blocking runtime failure until the conflict is resolved and a single constant set is kept.
Useful? React with 👍 / 👎.
|
|
||
| <label class="form-label mt-3" for="logo_scale">Logo size:</label> | ||
| <div class="logo-slider-wrap"> | ||
| <<<<<<< Updated upstream |
There was a problem hiding this comment.
The committed conflict block in app/templates/index.html ships merge-marker text and both slider variants, which duplicates id="logo_scale" and id="logo-scale-value" in the DOM while the script uses document.getElementById for a single element. In browsers this makes the logo-size UI inconsistent (only the first node is wired/updated) and exposes raw conflict markers to users.
Useful? React with 👍 / 👎.
1 participant
No description provided.