Skip to content

feat(TxDetail): refactor and improve styling#842

Merged
cstenglein merged 9 commits into
masterfrom
refactor-tx-detail
Dec 27, 2025
Merged

feat(TxDetail): refactor and improve styling#842
cstenglein merged 9 commits into
masterfrom
refactor-tx-detail

Conversation

@cstenglein
Copy link
Copy Markdown
Collaborator

@cstenglein cstenglein commented Nov 21, 2025

fixes #93

Before:
tx-detail-current

After:
grafik

@cstenglein
Copy link
Copy Markdown
Collaborator Author

Todo: Fee is missing

Copy link
Copy Markdown
Collaborator

@escapedcat escapedcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer! 👏 💅
Just some nits/suggestions/questions.

  • nit: Bottom padding looks off
    Image
  • I clicked the red entry but in the details I see green?
    Image

Comment thread src/pages/Home/TransactionCard/TransactionDetailModal/ConfirmationsRing.tsx Outdated
Comment thread src/pages/Home/TransactionCard/TransactionDetailModal/ConfirmationsRing.tsx Outdated
Comment thread src/pages/Home/TransactionCard/TransactionDetailModal/TransactionDetails.tsx Outdated
Comment thread src/pages/Home/TransactionCard/TransactionDetailModal/ConfirmationsRing.tsx Outdated
Comment thread src/pages/Home/TransactionCard/TransactionDetailModal/MempoolBadge.tsx Outdated
@escapedcat
Copy link
Copy Markdown
Collaborator

If we want to somewhat stick to conventional commits the comit should be i.e. "feat(TxDetail): refactor and improve styling"

@escapedcat
Copy link
Copy Markdown
Collaborator

Now that I think about it using SVG just to achieve a similar look to the progress icon we use seems a bit of an overhead.
Wouldn't it be possible to just use the same progress icons we use in the list but "just" show it bigger in the detail-modal?

Or just use something like this?

@cstenglein
Copy link
Copy Markdown
Collaborator Author

Thank you for the suggestions! Will address them soon! 🙏 👍

@cstenglein cstenglein changed the title (TxDetail): refactor and improve styling feat(TxDetail): refactor and improve styling Dec 8, 2025
@cstenglein
Copy link
Copy Markdown
Collaborator Author

Now that I think about it using SVG just to achieve a similar look to the progress icon we use seems a bit of an overhead. Wouldn't it be possible to just use the same progress icons we use in the list but "just" show it bigger in the detail-modal?

Or just use something like this?

Good idea!

@cstenglein
Copy link
Copy Markdown
Collaborator Author

With the ConfirmationIcons, it looks a bit weird:

grafik

So I'll be trying the CircularProgress

@escapedcat
Copy link
Copy Markdown
Collaborator

With the ConfirmationIcons, it looks a bit weird:

Does the job, not too bad I would say :)

@cstenglein
Copy link
Copy Markdown
Collaborator Author

With the CircularProgress:

grafik

@cstenglein cstenglein requested a review from escapedcat December 8, 2025 09:05
Comment thread src/pages/Home/TransactionCard/TransactionDetailModal/MempoolBadge.tsx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the transaction detail modal by consolidating the separate OnchainDetails and LNDetails components into a unified TransactionDetails component, while introducing several new reusable components and improving the overall styling and user experience.

Key Changes:

  • Unified transaction details display for both on-chain and Lightning transactions
  • Added interactive transaction ID component with expand/collapse and copy functionality
  • Introduced visual confirmation status indicator with circular progress ring
  • Created reusable card components for consistent styling

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
TransactionId.tsx New component for displaying transaction ID with expand/collapse toggle and copy-to-clipboard functionality
TransactionDetails.tsx Unified component that handles both on-chain and Lightning transaction details, replacing separate detail components
TransactionDetailModal.tsx Simplified to use the new unified TransactionDetails component instead of conditional rendering
MempoolBadge.tsx New component for displaying mempool.space link as a styled badge for on-chain transactions
KeyValueCard.tsx New reusable component for consistent key-value pair display with optional label support
ConfirmationsRing.tsx New component displaying confirmation status as an interactive circular progress indicator
OnchainDetails.tsx Removed - functionality consolidated into TransactionDetails
LNDetails.tsx Removed - functionality consolidated into TransactionDetails
en.json Added new translation keys for expand/collapse tooltips and additional transaction details
backend-mock/transactions.js Updated transaction indices for proper ordering in mock data

Comment thread src/pages/Home/TransactionCard/TransactionDetailModal/TransactionDetails.tsx Outdated
Comment thread src/pages/Home/TransactionCard/TransactionDetailModal/ConfirmationsRing.tsx Outdated
Comment thread src/pages/Home/TransactionCard/TransactionDetailModal/TransactionId.tsx Outdated
Comment thread src/pages/Home/TransactionCard/TransactionDetailModal/KeyValueCard.tsx Outdated
@cstenglein cstenglein merged commit 3d8cdce into master Dec 27, 2025
3 checks passed
@cstenglein cstenglein deleted the refactor-tx-detail branch December 27, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor TransactionDetailModal

3 participants