feat(TxDetail): refactor and improve styling#842
Conversation
6c18941 to
7f2ab5b
Compare
|
Todo: Fee is missing |
|
If we want to somewhat stick to conventional commits the comit should be i.e. "feat(TxDetail): refactor and improve styling" |
|
Now that I think about it using SVG just to achieve a similar look to the progress icon we use seems a bit of an overhead. Or just use something like this? |
|
Thank you for the suggestions! Will address them soon! 🙏 👍 |
7f2ab5b to
d3231f0
Compare
Good idea! |
Does the job, not too bad I would say :) |
There was a problem hiding this comment.
Pull request overview
This PR refactors the transaction detail modal by consolidating the separate OnchainDetails and LNDetails components into a unified TransactionDetails component, while introducing several new reusable components and improving the overall styling and user experience.
Key Changes:
- Unified transaction details display for both on-chain and Lightning transactions
- Added interactive transaction ID component with expand/collapse and copy functionality
- Introduced visual confirmation status indicator with circular progress ring
- Created reusable card components for consistent styling
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| TransactionId.tsx | New component for displaying transaction ID with expand/collapse toggle and copy-to-clipboard functionality |
| TransactionDetails.tsx | Unified component that handles both on-chain and Lightning transaction details, replacing separate detail components |
| TransactionDetailModal.tsx | Simplified to use the new unified TransactionDetails component instead of conditional rendering |
| MempoolBadge.tsx | New component for displaying mempool.space link as a styled badge for on-chain transactions |
| KeyValueCard.tsx | New reusable component for consistent key-value pair display with optional label support |
| ConfirmationsRing.tsx | New component displaying confirmation status as an interactive circular progress indicator |
| OnchainDetails.tsx | Removed - functionality consolidated into TransactionDetails |
| LNDetails.tsx | Removed - functionality consolidated into TransactionDetails |
| en.json | Added new translation keys for expand/collapse tooltips and additional transaction details |
| backend-mock/transactions.js | Updated transaction indices for proper ordering in mock data |
…tionsRing.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ionId.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ionId.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
82e848a to
7064ca1
Compare




fixes #93
Before:

After:
