Fix XLSX fidelity and checkpoint overhead - #12
Merged
Conversation
rastagan-git
marked this pull request as ready for review
July 22, 2026 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--forcefrom overwriting a checkpoint that another process replaced after this run created itPUG RESTfor PubChem rows where PUG-View was not attempted, while documenting the attempted-interface semantics0.3.2and update both READMEs plus the bundled curation SkillRoot cause
The preserved package kept the original
styles.xml, but the openpyxl round trip could omit or renumber a worksheet cell'ssreference. An untouched cell could therefore fall back to a non-trivialcellXfs[0]style. Checkpoint writes also usedDataFrame.iatfor every touched cell; pandas copied the growing workbook context fromframe.attrsduring those scalar accesses, multiplying serialization cost.User impact
Untouched workbook cells now retain their effective source formatting, including workbooks with a non-trivial base style. Checkpoints remain complete, openable
.partial.xlsxworkbooks, but their measured serialization overhead is substantially lower.--no-odorno longer claims PUG-View participation.Validation
python -m pytest -q: 94 passedpython -m ruff check .: passedpython -m ruff format --check .: passedquick_validate.py: passed0.3.2: passedFixes #11