fix: make PubChem CAS resolution conservative - #7
Merged
Conversation
rastagan-git
marked this pull request as ready for review
July 19, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--skip-pattern REGEXhandling so structural workbook rows can be excluded before any PubChem request.PubChem CAS Resolution,PubChem CAS Candidate Count, and configurableResolved CASoutput.$curate-aroma-dataskill.Root cause
The workbook workflow sent every identifier-shaped cell to PubChem and exported provider status together with raw CAS candidates. A valid PubChem record could therefore look like a resolved identity even when the row was structural, or when the record contained multiple or zero defensible CAS candidates.
Validation
ruff check .ruff format --check .pytest -q— 56 passedaromanexus-0.3.1-py3-none-any.whl; canonical and legacy namespaces plus both console entry points verifiedCloses #6