Change ov backend buffer is_host to false #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the OpenVINO backend buffer
is_hostflag to false, aligning it with the CPU repack buffer behavior.The OpenVINO backend buffer is conceptually similar to the CPU repack buffer. Both of them perform repacking (i.e., reordering) of quantized values. The OpenVINO backend goes further by performing additional processing such as extracting zero-points and related quantization metadata.
This change fixes the following issue.
In llama-model-loader.cpp, the loading logic is:
llama.cpp now uses direct I/O by default instead of mmap when loading models. Quantized weight extraction in the OpenVINO backend is implemented in
ggml_backend_tensor_set, so the code must take the non-host path. Therefore,ggml_backend_buffer_is_hostshould return false.