Fix mobile terminal soft keyboard input - #129
Merged
Merged
Conversation
…ner-mobile-input # Conflicts: # docs/session-runner-architecture.md
rawkintrevo
marked this pull request as ready for review
June 24, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #111.
This changes the runner-served xterm page so Mapache only applies visual hiding to xterm's helper textarea. The wrapper no longer forces that textarea offscreen, zero-sizes it, or clears its value on key/input events. xterm keeps ownership of helper textarea geometry and value state, which mobile soft keyboards and composition input rely on.
Root cause
The issue 97 helper-textarea cleanup was too aggressive for mobile browsers. Desktop Enter/hardware key paths still reached the PTY, but Android soft-keyboard printable characters depend on xterm's hidden textarea state.
Validation
Runner images pushed
Existing running sessions need a new session or runner revision to pick up the rebuilt images.