Skip to content

Issue 133: derive session target from workspace - #134

Merged
rawkintrevo merged 1 commit into
mainfrom
133-remove-cloud-type-choices-from-new-session-modal
Jun 25, 2026
Merged

Issue 133: derive session target from workspace#134
rawkintrevo merged 1 commit into
mainfrom
133-remove-cloud-type-choices-from-new-session-modal

Conversation

@rawkintrevo

Copy link
Copy Markdown
Owner

Closes #133.

Summary

  • Removed the session type chooser from the New session modal.
  • Derive cloud runner vs SSH session payloads from the selected workspace source.
  • Kept Cloud runner workspaces on the image selector and Dev machine workspaces on workspace-configured SSH sessions.
  • Updated frontend smoke coverage, QA manifest expectations, and frontend architecture docs.

Tests

  • npm run test:frontend
  • npm run docs:check
  • npm run build

Browser QA

  • Case path: e2e/qa/cases/session-create-basic.json via scripts/open-session-modal.json modal path
  • Result: passed
  • Evidence paths:
    • artifacts/qa/session.create-basic/new-session-modal.png
    • artifacts/qa/session.create-basic/new-session-modal.snapshot.txt
    • artifacts/qa/session.create-basic/result.json

Screenshot upload limitation: screenshots were captured locally under artifacts/qa, but the available workflow here did not provide a GitHub screenshot upload mechanism.

Notes

  • Browser QA observed the known local dev 404 for /__/firebase/init.json; QA login, Firebase token exchange, /api/me, /api/workspaces, and workspace data calls returned 200.

@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 496e707):

https://pi-agents-cloud--pr134-133-remove-cloud-typ-aulhqhoe.web.app

(expires Thu, 09 Jul 2026 11:11:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ad3a3866d5dcd316f5eca68b23f0ce7295063677

@rawkintrevo
rawkintrevo merged commit ed36dd8 into main Jun 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove cloud type choices from new session modal

1 participant