fix: unicode arrow parsing in trace logging and macOS temp path test#13
Open
AlexMikhalev wants to merge 2 commits into
Open
fix: unicode arrow parsing in trace logging and macOS temp path test#13AlexMikhalev wants to merge 2 commits into
AlexMikhalev wants to merge 2 commits into
Conversation
- Fix bash variable parsing on line 168 where unicode arrow (→) caused
unbound variable error for $DEPTH→ (changed to ${DEPTH}→)
- Fix test T14d hardcoded /tmp/ path that fails on macOS which uses
/var/folders/ for TMPDIR
The ypi script was not forwarding RLM_PROVIDER/RLM_MODEL to the root pi invocation, so the root session always used pi's default model (k2p5) instead of the configured model (glm-5). Now the root session starts with the configured provider/model, while child sessions continue to use RLM_CHILD_PROVIDER/RLM_CHILD_MODEL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$DEPTH→(changed to${DEPTH}→)/tmp/path that fails on macOS which uses/var/folders/for TMPDIRTesting
All 107 tests pass (35 unit + 72 guardrail):