Conversation
✅ Deploy Preview for wenbun-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the v0.29.0 release notes and refactors sync behavior to reduce server load by using a profile metadata endpoint and switching review log syncing from batch operations to per-review uploads.
Changes:
- Add v0.29.0 changelog entry on the About page.
- Optimize profile sync by fetching lightweight
/profiledata/metadatabefore deciding push/pull/conflict. - Remove batch review-log sync and upload individual review logs as they are created.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/routes/about/+page.svelte | Adds v0.29.0 changelog entry. |
| src/lib/profile.ts | Implements metadata-based profile sync and removes batch review-log sync methods. |
| src/lib/app.ts | Uploads each review log immediately when created. |
| src/lib/api.ts | Adds ProfileDataMetadata API route and removes ReviewLogMostRecent. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
228
to
+231
| const remoteProfileData = await this.getProfileData(); | ||
| const success = await Promise.all([ | ||
| this.updateProfileData(app.exportProfile(false), "pull"), | ||
| this.pullReviewLog(app, true), | ||
| ]); | ||
| const success = await this.updateProfileData(app.exportProfile(false), "pull"); | ||
| const success2 = await app.tryImportProfile(remoteProfileData, false, true); | ||
| if (success.every(s => s) && success2) { | ||
| if (success && success2) { |
Comment on lines
963
to
+966
| pushReviewLog(deckId: string, cardId: number, log: FSRS.ReviewLog): void { | ||
| this.reviewLogs.push({deckId, cardId, log}); | ||
| const reviewLog = {deckId, cardId, log}; | ||
| this.reviewLogs.push(reviewLog); | ||
| void this.profile.uploadReviewLog(reviewLog).catch(console.error); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.