Skip to content

[Data] Add q16 q19 to TPC-H test suite - #66515

Open
owenowenisme wants to merge 4 commits into
ray-project:masterfrom
owenowenisme:owenowenisme/add-tpch-q15-q19-to-release-test
Open

owenowenisme wants to merge 4 commits into
ray-project:masterfrom
owenowenisme:owenowenisme/add-tpch-q15-q19-to-release-test

Conversation

@owenowenisme

Copy link
Copy Markdown
Member

Description

As title described, this pr added q16 q19 to the TPCH tests which make tpc-h test suite completed.

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
@owenowenisme owenowenisme added data Ray Data-related issues go add ONLY when ready to merge, run all tests labels Sep 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces implementations for TPC-H Query 16 and Query 19 using Ray Data, and registers them in the nightly release data tests. The review feedback suggests significant performance optimizations for both queries: for Q16, optimizing the join order by performing the inner join before the left-anti join to reduce intermediate dataset size; and for Q19, pushing down filters (such as part clauses and global quantity bounds) to the source tables before executing the join to minimize shuffle overhead.

Comment thread release/nightly_tests/dataset/tpch/tpch_q16.py
Comment thread release/nightly_tests/dataset/tpch/tpch_q19.py
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Ray Data-related issues go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ray fails to serialize self-reference objects

1 participant