Repository navigation
Redact provider auth failures in compaction diagnostics - #1476
Merged
Merged
Conversation
7 of 53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redact auth-resolution failures in compaction diagnostics
Refs #1458 and #1442; both remain open.
The direct-request auth helper no longer unwraps provider errors or nested causes into public diagnostic text. Caught failures return a generic provider-login retry message. Missing-runtime/credential checks and successful auth assembly are unchanged.
Regression coverage checks direct, nested and non-Error failures. The synthetic remote-compaction fixture checks the fallback reason, structured logs, UI status/notifications and result details for credential sentinels. This fix concerns auth resolution; it does not certify arbitrary provider response errors, backup scans or custom-provider config migration.
No live accounts, inference, deployment or restart. All inference/provider behavior in the tests is mocked.
Validation
Focused auth/model-request/smart-compaction suites: 206 pass, 767 assertions. Five typechecks and scoped lint pass. Independent source review found no blocker.
The initial full run passed 5,925 tests but hit three unrelated 15-second DB/SQLite test timeouts. The unchanged serial suites passed 82 tests and 1,137 assertions. After merging retry-log #1475 (baseline
8023285a4), the auth suites passed again at 206/767 and a complete unchangedmake ci-fastrerun passed 5,929 runtime tests, seven existing skips and no failures, plus 25 feature tests and nine web checks. No timeouts, limits or test exclusions changed. Pack hygiene passed 24,741 files; final five typechecks and diff checks passed with the unchanged 95-diagnostic compose baseline. Private Bun caches used.