Separate custom provider credentials from model configuration - #1477
Merged
Merged
Conversation
5 of 48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate new custom-provider keys from model configuration
Refs #1458 and #1442; both stay open.
models.jsonentries. Save new submitted keys through public composed-providerModelRuntime.login()using the existing Piclaw credential backend.apiKeyfields from new backups, and stop auth.json snapshots on logout.Legacy target config keys fail closed before mutation. Historical backups are untouched. This does not claim legacy migration, cross-process config transactions, complete backup/header/URL scanning, all keyless endpoint availability or full AUTH-04/05/06 acceptance. No live account, inference, deployment or restart.
Validation
Thirteen real public-runtime/file-store child scenarios passed 39 parent assertions plus child assertions; related handler/isolation/card suites passed 52/408. Combined twelve-case set passed 64/444 before adding the final commit-window case. Five standard types, strict fixture types, scoped lint and diff checks pass. Independent review findings corrected; final scoped source review found no blocker. The frozen canonical gate passed 5,942 runtime tests, seven existing skips and no failures, plus 25 feature and nine web checks. Pack hygiene passed 24,741 files. Final five types and diff checks passed at baseline
2b0f5aaa3; unchanged 95-diagnostic compose baseline. Private Bun cache, no shared-cache permission changes.