Repository navigation
Qualify cross-process provider credential ownership - #1479
Merged
Merged
Conversation
7 of 53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-process credential ownership qualification
Refs #1458 and #1442; both stay open.
The public app-store subclass observes entry/rejection only; it delegates to the real store and never patches SDK internals. IPC carries events/commands only. No provider network, inference, live credentials, deployment or restart.
This proves serialization/pre-write holder recovery, not crash-safe file writes. Current in-place writeFileSync overwrite can corrupt under mid-write loss; that durability boundary, legacy backups, complete CLI/device/Delegate/live acceptance remain open.
Validation
Opt-in full fixture: 4 pass / 35 assertions plus child assertions. Post-merge fast+lifecycle: 9 pass / 42 assertions, one documented slow opt-in skip. Strict fixtures, five types and scoped lint pass. Review corrected barriers, rejection fence, final cardinality and termination signal; rereview green. Canonical gate: 5,954 passed, eight skipped, zero failed; 25 feature and nine web checks passed. Seven existing skips plus the documented slow opt-in crash case (separately passed). Pack hygiene: 24,741 files; final five types/diff passed at baseline
7ed2e7187, unchanged compose baseline. Initial static guard caught an empty cleanup catch; corrected error propagation/finally cleanup passed guard and full gate with no relaxed limits. Environment snapshot change is docs-only opt-in reference, no production readers.