Repository navigation
Replace provider credential files atomically - #1480
Merged
Merged
Conversation
7 of 53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace credential files atomically
Refs #1458 and #1442; both stay open.
wx0600 file, fsync/close it, atomically rename and sync the POSIX directory under the existing cross-process lock.wx.Scope is app-owned private POSIX parent and process-crash visibility. No power-loss/Windows/general filesystem certification, owning-UID/ancestor attack guarantee or automatic orphan staging cleanup. Abrupt death may leave a private credential-bearing temp file; retention needs separate review. Legacy secrets/backups, full provider/CLI/device/Delegate/live acceptance stay open.
No live accounts, inference, deployment or restart. App-owned fault I/O seam; no private SDK imports or lock-option/clock manipulation.
Validation
Failure/store/crash set: 30 pass / 166 assertions. Post-crossprocess-merge lifecycle/store/crossprocess opt-in set: 40 pass / 219. All five types, strict fixture types, scoped lint, diff and scoped independent review pass. One initial unchanged concurrency test hit its existing five-second budget; unchanged rerun22/115 passed with no timeout changes. Frozen canonical gate: 5,969 passed, eight skipped, zero failures; 25 feature and nine web checks passed. Pack hygiene: 24,742 files. Final five types/diff passed at baseline
e7539b67a; unchanged compose baseline. Seven existing skips plus prior opt-in stale-lock case separately passed in the 40-test run. Private Bun cache, shared-cache permissions unchanged.